RFR: 8325520: Vector loads with offsets incorrectly compiled [v11]

Damon Fenacci dfenacci at openjdk.org
Tue May 21 13:47:33 UTC 2024


On Tue, 21 May 2024 06:48:12 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.hpp line 979:
>> 
>>> 977:                                                     idx == MemNode::ValueIn ||
>>> 978:                                                     idx == MemNode::ValueIn + 1; }
>>> 979:    virtual Node* offsets() const { return in(Offsets); }
>> 
>> Would be nice to add some `override` keywords here ;)
>
> And also below.

`override` added

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1608363723


More information about the hotspot-compiler-dev mailing list