RFR: 8328998: Encoding support for Intel APX extended general-purpose registers [v22]

Tue May 21 17:44:10 UTC 2024

On Tue, 21 May 2024 17:11:16 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Thanks.  I added a comment.
>
> Is it enough to have AVX512F present for APX? What about Knight CPUs which have limited AVX512 features?

You should add code which checks CPUID features bit to set `UseAPX`. Or set it to `false` unconditionally in this PR regardless UseAVX value with comment "APX is not supported on this CPU". Otherwise someone will switch it on command line on avx512 machine.

Or we should push [#18562](https://github.com/openjdk/jdk/pull/18562) first. Which I prefer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18476#discussion_r1608681738