RFR: 8325520: Vector loads with offsets incorrectly compiled [v12]

[Tobias Hartmann]

On Wed, 22 May 2024 07:42:28 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8325520: add override keyword
>
> src/hotspot/share/opto/vectornode.hpp line 893:
> 
>> 891: class LoadVectorGatherNode : public LoadVectorNode {
>> 892:  public:
>> 893:   enum { Offsets = 3 };
> 
> Just wondering about the naming convention here because the corresponding constructor argument is called `indices`. Should that be consistent?

Also, where is this used?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1609471219