RFR: 8320725: C2: Add "requires_strict_order" flag for floating-point add-reduction [v10]
Emanuel Peter
epeter at openjdk.org
Fri May 24 08:53:12 UTC 2024
On Fri, 24 May 2024 08:30:38 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorFPReduction.java line 32:
>>
>>> 30: * @bug 8320725
>>> 31: * @summary Ensure strictly ordered AddReductionVF/VD nodes are generated on SVE machines
>>> 32: * while being disabled on Neon
>>
>> Suggestion:
>>
>> * while being disabled on Neon
>
> nit: we usually indent the second line with the start of the summary-text of the first line.
I would also like a more general summary here, that is less ARM specific. Talk more about `requires_strict_order` and `no_strict_order`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18034#discussion_r1613102744
More information about the hotspot-compiler-dev
mailing list