RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v6]

Yudi Zheng yzheng at openjdk.org
Fri May 24 14:55:08 UTC 2024


On Thu, 23 May 2024 10:12:17 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

>> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address comments.
>
> src/hotspot/share/opto/library_call.cpp line 5925:
> 
>> 5923:   // Set the original stack and the reexecute bit for the interpreter to reexecute
>> 5924:   // the bytecode that invokes BigInteger.multiplyToLen() if deoptimization happens
>> 5925:   // on the return from z array allocation in runtime.
> 
> Since we are not allocating z array during runtime anymore, do we still need these comments?

Thanks for pointing it out! Removed.

> src/java.base/share/classes/java/math/BigInteger.java line 1836:
> 
>> 1834: 
>> 1835:         if (z == null || z.length < (xlen + ylen))
>> 1836:              z = new int[xlen + ylen];
> 
> Style: only 4 spaces indentation

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18226#discussion_r1613608426
PR Review Comment: https://git.openjdk.org/jdk/pull/18226#discussion_r1613608653


More information about the hotspot-compiler-dev mailing list