RFR: 8332402: [IR Framework] Add tests for applyIfCPUFeature* and applyIfPlatform* in TestBadFormat

[Emanuel Peter]

On Tue, 21 May 2024 08:12:17 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch to add some test for IR test framework?
>> As discussed https://github.com/openjdk/jdk/pull/19270#pullrequestreview-2060974799, it's worth to add some tests for for applyIfCPUFeature* and applyIfPlatform* in TestBadFormat.
>> 
>> Thanks
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestBadFormat.java line 861:
> 
>> 859:     public void onlyOneApplyIfCPUFeature() {}
>> 860: 
>> 861:     @FailCount(3)
> 
> Why are there 3 failures?

Generally, the count is not always as I would expect. Can we fix that? You should at least comment what fails, and why.

I would expect there to be a single failure per rule. But that seems not to be the case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19302#discussion_r1607854475