RFR: 8332499: Gtest codestrings.validate_vm fail on linux x64 when hsdis is present [v5]
SendaoYan
syan at openjdk.org
Tue May 28 15:47:25 UTC 2024
> Hi all,
> There's some arch-specific code to trim trailing entries as descripted in [JDK-8332499](https://bugs.openjdk.org/browse/JDK-8332499). Only change the gtest testcase, the risk is low.
>
> On linux x86_64, before this PR, after deal with `std::regex_replace(tmp4, std::regex("\\s+<addr>:\\s+hlt[ \\t]+(?!\\n\\s+;;)"), "")`, the output differents because the first output has trailing empty space, show as below:
>
> - <addr>: nop
> + <addr>: nop
>
> So we need to delete the empty spaces after `<addr>: nop` use `std::regex_replace(tmp5, std::regex("(\\s+<addr>:\\s+nop)[ \\t]*"), "$1")`
>
>
> Additional test:
> - [x] codestrings.validate_vm on linux x64
> - [x] codestrings.validate_vm on linux aarch64
> - [x] codestrings.validate_vm on linux riscv64
SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
- Merge branch 'jbs8332499' of github.com:sendaoYan/jdk-ysd into jbs8332499
- delete the empty spaces after <addr>: nop
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19309/files
- new: https://git.openjdk.org/jdk/pull/19309/files/1c017d20..1f1ae322
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19309&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19309&range=03-04
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/19309.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19309/head:pull/19309
PR: https://git.openjdk.org/jdk/pull/19309
More information about the hotspot-compiler-dev
mailing list