RFR: 8332499: Gtest codestrings.validate_vm fail on linux x64 when hsdis is present [v4]
SendaoYan
syan at openjdk.org
Tue May 28 15:47:25 UTC 2024
On Tue, 28 May 2024 11:13:22 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> Could you please explain why the test fails and how your fix addresses the issue?
On linux x86_64, before this PR, after deal with `std::regex_replace(tmp4, std::regex("\\s+<addr>:\\s+hlt[ \\t]+(?!\\n\\s+;;)"), "")`, the output differents because the first output has trailing empty space, show as below:
- <addr>: nop
+ <addr>: nop
So we need to delete the empty spaces after `<addr>: nop` use `std::regex_replace(tmp5, std::regex("(\\s+<addr>:\\s+nop)[ \\t]*"), "$1")`
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19309#issuecomment-2135576744
More information about the hotspot-compiler-dev
mailing list