RFR: 8320448: Accelerate IndexOf using AVX2 [v49]

[Scott Gibbons]

On Thu, 30 May 2024 13:50:01 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Stupid EOL at end
>>  - Add @test block; fix test indentation
>
> test/jdk/java/lang/String/IndexOf.java line 25:
> 
>> 23: 
>> 24: /*
>> 25:  * @test
> 
> You should add the `@bug 8320448` for all runs.

Done.

> test/jdk/java/lang/String/IndexOf.java line 27:
> 
>> 25:  * @test
>> 26:  * @summary test String indexOf() intrinsic
>> 27:  * @run main/othervm IndexOf
> 
> Suggestion:
> 
>  * @run main IndexOf
> 
> You do not need a new VM if you have no arguments ;)

Done.

> test/jdk/java/lang/StringBuffer/ECoreIndexOf.java line 25:
> 
>> 23: 
>> 24: /* @test
>> 25:  * @bug 4162796 4162796
> 
> You need to fix the bug numbers.

Done.

> test/jdk/java/lang/StringBuffer/ECoreIndexOf.java line 27:
> 
>> 25:  * @bug 4162796 4162796
>> 26:  * @summary Test indexOf and lastIndexOf
>> 27:  * @run main/othervm -Xbatch -XX:-TieredCompilation -XX:CompileCommand=dontinline,ECoreIndexOf.indexOfKernel ECoreIndexOf
> 
> I would also add a line without `-XX:-TieredCompilation`, then C1 can be tested with this too

Done.

> test/jdk/java/lang/StringBuffer/ECoreIndexOf.java line 32:
> 
>> 30: 
>> 31: /* @test
>> 32:  * @bug 4162796 4162796
> 
> Here too

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1620951690
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1620949315
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1620945040
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1620947641
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1620945484