RFR: 8335392: C2 MergeStores: enhanced pointer parsing [v16]

[Emanuel Peter]

On Mon, 4 Nov 2024 09:41:40 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more review applications
>
> src/hotspot/share/opto/mempointer.cpp line 45:
> 
>> 43:   while (_worklist.is_nonempty()) {
>> 44:     // Bail out if the graph is too complex.
>> 45:     if (traversal_count++ > 1000) { return MemPointerDecomposedForm(pointer); }
> 
> Might be easier to read/understand when we also have `MemPointerDecomposedForm::make_trivial(pointer)` method. What do you think? Then `MemPointerDecomposedForm(pointer)` can also be made private.

Good idea!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19970#discussion_r1827584414