RFR: 8344371: RISC-V: compiler/intrinsics/chacha/TestChaCha20.java fails after JDK-8343555
Fei Yang
fyang at openjdk.org
Tue Nov 19 01:52:50 UTC 2024
On Mon, 18 Nov 2024 11:44:51 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> From the error message, the cause of the failure is that 'UseRVV' was made diagnostic in [JDK-8343555](https://bugs.openjdk.org/browse/JDK-8343555). But the test was not updated to refect this. Instead of adding one extra `-XX:+UnlockDiagnosticVMOptions` option, this simply removed the use of `-XX:+UseRVV` from the test. The reason is that we have `-XX:+UseRVV` auto detected and enabled, so we will have RVV extension if we satisfy the test requirement:
>>
>> (os.arch == "riscv64" & vm.cpu.features ~= ".*rvv.*")
>>
>>
>> Same test pass with this fix on linux-riscv64 with RVV extension.
>
> Looks good. Thanks for catching this.
@Hamlin-Li : Thanks for the review! Moving on.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22188#issuecomment-2484536564
More information about the hotspot-compiler-dev
mailing list