RFR: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize
SendaoYan
syan at openjdk.org
Wed Nov 20 03:10:24 UTC 2024
On Wed, 20 Nov 2024 02:52:40 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Hi all,
>> Currently on linux-riscv64 platform the debug VM option `-XX:+VerifyActivationFrameSize` is Unimplemented. I want to implement `-XX:+VerifyActivationFrameSize` to make JVM easier to diagnose. Only effect debug build plus with option `-XX:+VerifyActivationFrameSize`, the change has been verified locally, the risk is low.
>>
>> Additional testing
>>
>> - [ ] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 release build
>
> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 447:
>
>> 445: sub(t1, fp, esp);
>> 446: int min_frame_size = (frame::link_offset - frame::interpreter_frame_initial_sp_offset) * wordSize;
>> 447: add(t1, t1, -min_frame_size);
>
> Suggestion: `sub(t1, t1, min_frame_size);`
Thanks, the `add` has been replaced as `sub`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22264#discussion_r1849438199
More information about the hotspot-compiler-dev
mailing list