RFR: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize
Fei Yang
fyang at openjdk.org
Wed Nov 20 04:15:15 UTC 2024
On Wed, 20 Nov 2024 02:43:42 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
> Currently on linux-riscv64 platform the debug VM option `-XX:+VerifyActivationFrameSize` is Unimplemented. I want to implement `-XX:+VerifyActivationFrameSize` to make JVM easier to diagnose. Only effect debug build plus with option `-XX:+VerifyActivationFrameSize`, the change has been verified locally, the risk is low.
>
> Additional testing
>
> - [ ] jtreg tests(include tier1/2/3 etc.) on linux-riscv64 release build
src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 445:
> 443: if (VerifyActivationFrameSize) {
> 444: Label L;
> 445: sub(t1, fp, esp);
Note that RISC-V is a bit different in frame structure from other CPU platforms. I think we should exlcude the 2 frame metadata words after this `sub`, like:
sub(t1, t1, frame::metadata_words * wordSize); // Exclude 2 frame metadata words
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22264#discussion_r1849476179
More information about the hotspot-compiler-dev
mailing list