RFR: 8340010: Fix vectorization tests with compact headers

[Roberto Castañeda Lozano]

On Thu, 21 Nov 2024 10:26:38 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorization/runner/ArrayTypeConvertTest.java line 111:
>> 
>>> 109:     // ---------------- Integer Extension ----------------
>>> 110:     @Test
>>> 111:     @IR(failOn = {IRNode.STORE_VECTOR})
>> 
>> Not sure if it's necessary to fail on the Node, I'm not an expert, so just a question, not a review comment. Similar question for the below  `failOn`s
>
> I think it makes sense to add a `failOn` here. We have an RFE that tracks this, and when it is implemented, we should expect this test to "fail", i.e. the vectorization succeeds. Then it would be nice if we can enable a positive IR rule. So I put in a negative now, so we don't forget to put in a positive later.

@eme64 I agree with having the negative check but please make the intention clearer in the comment. E.g. "Subword vector casts do not work currently. Assert the vectorization failure so that we are reminded to update the test when this limitation is addressed in the future."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22199#discussion_r1851851295