RFR: 8340010: Fix vectorization tests with compact headers
Emanuel Peter
epeter at openjdk.org
Thu Nov 21 11:17:22 UTC 2024
On Thu, 21 Nov 2024 11:07:49 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> I think it makes sense to add a `failOn` here. We have an RFE that tracks this, and when it is implemented, we should expect this test to "fail", i.e. the vectorization succeeds. Then it would be nice if we can enable a positive IR rule. So I put in a negative now, so we don't forget to put in a positive later.
>
> @eme64 I agree with having the negative check but please make the intention clearer in the comment. E.g. "Subword vector casts do not work currently. Assert the vectorization failure so that we are reminded to update the test when this limitation is addressed in the future."
That is why I wrote this comment:
`// Subword vector casts do not work currently, see JDK-8342095.`
But I can extend the comment if you like.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22199#discussion_r1851858597
More information about the hotspot-compiler-dev
mailing list