RFR: 8340010: Fix vectorization tests with compact headers
Hamlin Li
mli at openjdk.org
Thu Nov 21 11:17:22 UTC 2024
On Thu, 21 Nov 2024 11:12:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> @eme64 I agree with having the negative check but please make the intention clearer in the comment. E.g. "Subword vector casts do not work currently. Assert the vectorization failure so that we are reminded to update the test when this limitation is addressed in the future."
>
> That is why I wrote this comment:
> `// Subword vector casts do not work currently, see JDK-8342095.`
> But I can extend the comment if you like.
I see, thanks for explanation!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22199#discussion_r1851859528
More information about the hotspot-compiler-dev
mailing list