RFR: 8344833: CTW: Make failing on zero classes optional

[Tobias Hartmann]

On Fri, 22 Nov 2024 11:11:55 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

> For CTW, zero classes in provided jar is now a failure.
> This creates noisy and blocking false positives in fuzzy/mass scale runs, where we use jar archives from random sources, unchecked or randomly generated, etc.
> 
> This PR makes this behaviour controllable. Default reaction is a failure, like before.

Changes requested by thartmann (Reviewer).

test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/CtwRunner.java line 179:

> 177:         boolean allowZeroClassCount = Boolean.getBoolean("sun.hotspot.tools.ctw.allow_zero_class_count");
> 178:         if (allowZeroClassCount && classCount == 0L) {
> 179:             System.out.println("WARN: " + target + "(at " + targetPath + ") have not classes. Ignoring.");

Suggestion:

            System.out.println("WARN: " + target + "(at " + targetPath + ") has no classes. Ignoring.");

-------------

PR Review: https://git.openjdk.org/jdk/pull/22320#pullrequestreview-2457336184
PR Review Comment: https://git.openjdk.org/jdk/pull/22320#discussion_r1855913391