RFR: 8344833: CTW: Make failing on zero classes optional

Vladimir Kozlov kvn at openjdk.org
Tue Nov 26 17:34:44 UTC 2024


On Fri, 22 Nov 2024 11:11:55 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

> For CTW, zero classes in provided jar is now a failure.
> This creates noisy and blocking false positives in fuzzy/mass scale runs, where we use jar archives from random sources, unchecked or randomly generated, etc.
> 
> This PR makes this behaviour controllable. Default reaction is a failure, like before.

What is default value of `allow_zero_class_count` and where it is set?

Why you even need this to be controlled and not default behavior? What is benefit of having error vs warning for empty `jar`?

Should you check `totalClassCount` too to catch empty `jar`? As I see `classCount` could be 0 if specified `classStart` and `classStop` as the same which could happened regardless number of classes in `jar` file.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22320#pullrequestreview-2462269167


More information about the hotspot-compiler-dev mailing list