RFR: 8344026: Ubsan: prevent potential integer overflow in c1_LIRGenerator_<arch>.cpp file [v7]

Amit Kumar amitkumar at openjdk.org
Mon Nov 25 13:44:04 UTC 2024


On Mon, 25 Nov 2024 13:36:32 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp line 280:
>> 
>>> 278: 
>>> 279: bool LIRGenerator::strength_reduce_multiply(LIR_Opr left, jint c, LIR_Opr result, LIR_Opr tmp) {
>>> 280:   unsigned int u_value = (juint)c;
>> 
>> Keep the type names consistent.
>> Suggestion:
>> 
>>   juint u_value = (juint)c;
>
> I think we're done now with this change. What are your plans to test the Arm 32-bit version?

I don't have hardware for arm32 :(

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22144#discussion_r1856636261


More information about the hotspot-compiler-dev mailing list