RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v3]
Emanuel Peter
epeter at openjdk.org
Mon Nov 25 14:39:22 UTC 2024
On Mon, 25 Nov 2024 14:27:44 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> @eme64 I didn't mean to imply it's not useful. But I think it would be better to do these changes to the existing code for ModI/L and DivI/L in a separate RFE.
>
> I don't see the logic in "Doing it the same as `ModI/LNode` then changing all of them together" instead of "Doing the new thing in the better way then changing the old thing to match it"
Yeah, it is a trade-off. I think this here is small enough to just change it now in the same RFE. But if you prefer to do it in a separate RFE, that's fine too for me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22061#discussion_r1856728255
More information about the hotspot-compiler-dev
mailing list