RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v3]

[theoweidmannoracle]

On Mon, 25 Nov 2024 14:36:52 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> I don't see the logic in "Doing it the same as `ModI/LNode` then changing all of them together" instead of "Doing the new thing in the better way then changing the old thing to match it"
>
> Yeah, it is a trade-off. I think this here is small enough to just change it now in the same RFE. But if you prefer to do it in a separate RFE, that's fine too for me.

If I make these changes here now, I need to come up with tests for these uncasts, which will probably take me a while (I have no experience with this yet and I can't tell how long it might take me) and the PR will stall in the meantime. If I open a follow-up RFE, I can take a look at this independently and this PR, whose main intention was to take over the main applicable optimizations from the signed to unsigned can be merged already. So as @eme64 says, it's a trade-off between creating the perfect PR now or getting some good changes in and then making refinements in the same area in a later, follow-up PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22061#discussion_r1856749607