RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v3]
theoweidmannoracle
duke at openjdk.org
Thu Nov 28 10:11:39 UTC 2024
On Mon, 25 Nov 2024 15:00:40 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Drive-by comment: Such uncast optimizations are definitely non-trivial changes as they tend to trigger other issues by allowing subgraphs to be folded that would otherwise not be folded. So let's make sure we have proper tests for this. In my opinion, putting some of this work into a separate RFE is perfectly fine.
>
> This is fair, but this point does not apply to my other suggestions. though. Btw `eqv_uncast` is used in `XorNode::Value`.
Other comments were addressed. RFE for this one: https://bugs.openjdk.org/browse/JDK-8345170
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22061#discussion_r1861875156
More information about the hotspot-compiler-dev
mailing list