RFR: 8345039: IGV: save user-defined node colors to XML

[Roberto Castañeda Lozano]

On Thu, 28 Nov 2024 15:15:06 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

> This PR depends on https://github.com/openjdk/jdk/pull/22402 
> 
> [JDK-8343535](https://bugs.openjdk.org/browse/JDK-8343535) introduced the possibility to give user-defined colors to a node.
> The colors are lost when the user goes to the next graph or when IGV is closed. Save the colors as a property of the graph to the XML to make it more permanent. This requires that the user can also remove the colors again.
> 
> <img width="474" alt="color" src="https://github.com/user-attachments/assets/c994f93c-7db1-40e6-9963-2f5417cec77f">
> 
> ### Whats new
> - Now colors are saved with the XML as well
> - Colors are kept when changing to a different graph
> - The user can remove the color again: This uses the color from the filter or WHITE otherwise

> > So, the only minor problem left is the "No..." that does not look like a button and therefore is not suggesting to click it. Maybe you find a fix for that. If not, I guess it's okay to move forward with this patch and come back to it later again.
> 
> This small adjustment should address that part: [a5f6562](https://github.com/openjdk/jdk/commit/a5f6562f86481316ae36fc629bb9d5efae7f3e2f). Could you please try it out?

Here's a revised version of the adjustment that also makes the button look clickable (thanks to @chhagedorn  for trying out and adjusting the button settings to prevent label truncation and ugly button focus shape): https://github.com/openjdk/jdk/commit/aba8d3e253cc2fd7c33d0d00ea9f014fdaa37e3d. @tobiasholenstein feel free to incorporate and edit to your liking.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22440#issuecomment-2507411406