RFR: 8345039: IGV: save user-defined node colors to XML [v5]

[Christian Hagedorn]

On Fri, 29 Nov 2024 14:50:16 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> This PR depends on https://github.com/openjdk/jdk/pull/22402 
>> 
>> [JDK-8343535](https://bugs.openjdk.org/browse/JDK-8343535) introduced the possibility to give user-defined colors to a node.
>> The colors are lost when the user goes to the next graph or when IGV is closed. Save the colors as a property of the graph to the XML to make it more permanent. This requires that the user can also remove the colors again.
>> 
>> <img width="474" alt="color" src="https://github.com/user-attachments/assets/c994f93c-7db1-40e6-9963-2f5417cec77f">
>> 
>> ### Whats new
>> - Now colors are saved with the XML as well
>> - Colors are kept when changing to a different graph
>> - The user can remove the color again: This uses the color from the filter or WHITE otherwise
>
> Tobias Holenstein has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - fixes after merge
>  - reverts
>  - readd imports

This is a nice enhancement! As discussed offline, we could follow up with RFEs (if wanted) to handle:
- Save colors added in the diff view when having graph "X vs. X + 4" opened and going to the next graph, e.g. "X vs X + 3". It currently drops the color.
- When cloning a graph, making the coloring local and not globally per XML. Now when you color a node in one of the graphs, it will be applied to the original and the cloned graph.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22440#pullrequestreview-2470146316