Integrated: 8345039: IGV: save user-defined node colors to XML
Tobias Holenstein
tholenstein at openjdk.org
Fri Nov 29 15:24:44 UTC 2024
On Thu, 28 Nov 2024 15:15:06 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
> This PR depends on https://github.com/openjdk/jdk/pull/22402
>
> [JDK-8343535](https://bugs.openjdk.org/browse/JDK-8343535) introduced the possibility to give user-defined colors to a node.
> The colors are lost when the user goes to the next graph or when IGV is closed. Save the colors as a property of the graph to the XML to make it more permanent. This requires that the user can also remove the colors again.
>
> <img width="474" alt="color" src="https://github.com/user-attachments/assets/c994f93c-7db1-40e6-9963-2f5417cec77f">
>
> ### Whats new
> - Now colors are saved with the XML as well
> - Colors are kept when changing to a different graph
> - The user can remove the color again: This uses the color from the filter or WHITE otherwise
This pull request has now been integrated.
Changeset: a80ccf2c
Author: Tobias Holenstein <tholenstein at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/a80ccf2cd2792c24b51f1143cb0e6c5b036c5b28
Stats: 75 lines in 6 files changed: 69 ins; 0 del; 6 mod
8345039: IGV: save user-defined node colors to XML
Co-authored-by: Roberto Castañeda Lozano <rcastanedalo at openjdk.org>
Co-authored-by: Christian Hagedorn <chagedorn at openjdk.org>
Reviewed-by: chagedorn, epeter, rcastanedalo
-------------
PR: https://git.openjdk.org/jdk/pull/22440
More information about the hotspot-compiler-dev
mailing list