RFR: 8345041: IGV: Free Placement Mode in IGV Layout [v2]

[Tobias Holenstein]

On Thu, 28 Nov 2024 14:52:49 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/utils/IdealGraphVisualizer/HierarchicalLayout/src/main/java/com/sun/hotspot/igv/hierarchicallayout/FreeInteractiveLayoutManager.java line 219:
>> 
>>> 217: 
>>> 218:                 double deltaX = posX - otherNode.getX();
>>> 219:                 double deltaY = posY - otherNode.getY();
>> 
>> What happens if this distance is zero? Does the division below behave ok?
>
> If we get issues here, we can always check for zero and add some random non-zero noise to force different position to get the two nodes to separate in a sane way.

right! It should be fixed now

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22438#discussion_r1863794505