RFR: 8345041: IGV: Free Placement Mode in IGV Layout [v2]
Tobias Holenstein
tholenstein at openjdk.org
Sat Nov 30 00:15:20 UTC 2024
On Thu, 28 Nov 2024 14:55:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Tobias Holenstein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
>>
>> - JDK-8345041 IGV: Free Placement Mode in IGV Layout
>>
>> fix
>> - Merge branch 'pr/22402' into JDK-8343705
>> - revert copyright changes
>> - 8343705: IGV: Interactive Node Moving in Hierarchical Layout
>> - fixed graph objects equality
>> - remove executability of igv.sh
>> - update Figure height calculation for Slots
>> - run IGV without asserts
>> - batch add connectionLayer.addChildren(newWidgets);
>> - remove dead code in LineWidget
>> - ... and 7 more: https://git.openjdk.org/jdk/compare/b9c6ce90...4f7ca8ee
>
> This is really amazing, the feature. Really would make me start using IGV.
>
> I scanned the code changes quickly, and it seems reasonable, at least to a non-IGV developer 😅
Thanks @eme64, @robcasloz and @chhagedorn for testing and reviewing!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22438#issuecomment-2508746746
More information about the hotspot-compiler-dev
mailing list