RFR: 8340214: C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop [v3]

[Roland Westrelin]

On Wed, 2 Oct 2024 12:30:30 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> > As further clean up, maybe we want to drop the slice argument to GraphKit::make_load() and GraphKit::store_to_memory() (and to their callers) given it's redundant with the address type and error prone.
> 
> Yes, let's do that. Please file a starter RFE.

https://bugs.openjdk.org/browse/JDK-8341411

> src/hotspot/share/opto/compile.cpp line 1475:
> 
>> 1473:         assert(tj == TypeInstPtr::make(to->ptr(), canonical_holder, is_known_inst, nullptr, offset, instance_id), "exact type should be canonical type");
>> 1474:       } else {
>> 1475:         assert(xk || !is_known_inst, "Known instance should be exact type");
> 
> Maybe add a comment here and explain the two cases when we create a new type.

Done in new commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21303#issuecomment-2388631754
PR Review Comment: https://git.openjdk.org/jdk/pull/21303#discussion_r1784521453