RFR: 8340214: C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop [v3]

[Tobias Hartmann]

On Wed, 2 Oct 2024 13:21:34 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/compile.cpp line 1475:
>> 
>>> 1473:         assert(tj == TypeInstPtr::make(to->ptr(), canonical_holder, is_known_inst, nullptr, offset, instance_id), "exact type should be canonical type");
>>> 1474:       } else {
>>> 1475:         assert(xk || !is_known_inst, "Known instance should be exact type");
>> 
>> Maybe add a comment here and explain the two cases when we create a new type.
>
> Done in new commit.

Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21303#discussion_r1784537173