RFR: 8339507: Test generation tool and gtest for testing APX encoding of extended gpr instructions [v4]

hanklo6 duke at openjdk.org
Fri Oct 18 21:14:22 UTC 2024


On Thu, 17 Oct 2024 02:07:59 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> test/hotspot/gtest/x86/x86-asmtest.py line 655:
>> 
>>> 653: }
>>> 654: 
>>> 655: for RegOp, ops in instruction_set.items():
>> 
>> Rest of the code is modular, can you kindly refactor below code into a top level routine called from __main__ method.
>
> Binutils toolset is specific to Linux. Should we not add relevant OS.name check and exit?

Thanks, done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20857#discussion_r1807019816


More information about the hotspot-compiler-dev mailing list