RFR: 8339507: Test generation tool and gtest for testing APX encoding of extended gpr instructions [v4]

[hanklo6]

On Thu, 17 Oct 2024 12:36:27 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> hanklo6 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>> 
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into apx-test-tool
>>  - Add comment and defined
>>  - Add copyright header
>>  - Remove tab
>>  - Remove whitespace
>>  - Replace whitespace with tab
>>  - Add flag before testing
>>  - Fix assertion error on MacOS
>>  - Add _LP64 flag
>>  - Add missing header
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/0ac393c7...ca48f240
>
> test/hotspot/gtest/x86/test_assemblerx86.cpp line 99:
> 
>> 97:   asm_check((const uint8_t *)entry, (const uint8_t *)insns, insns_lens, insns_strs, sizeof(insns_lens) / sizeof(insns_lens[0]));
>> 98:   BufferBlob::free(b);
>> 99: }
> 
> Following MAP0 and MAP1 instructions are missing :-
> 
> bsfl   bsfq  bsrl  bsrq bswapl bswapq
> btq  
> call
> cmpb cmpl cmpq cmpw
> cmpxchgb  cmpxchgl cmpxchgq cmpxchgw
> cvttsd2siq
> incl incq
> lea leal  leaq 
> mov mov64  movb movl movq
> movsbl movsbq movslq movswl movswq
> movw 
> movzbl movzbq movzwl movzwq
> orw
> sall salq
> testb testl testq
> xaddb xaddl xaddq xaddw
> xchgb xchgl xchgq xchgw
> 
> 
> But, given that all assembly routines share same leaf level prefix emitting routines, we can skip them for the time being or add validate just one from each row  
> 
> Please do add following new MAP4 APX instructions since you are already taking care of their two operand counterparts with PPX.
> 
> 1. popp
> 2. pushp

Thanks, I added the missing instructions. For the `incl` and `incq`, I tested them through the `incrementl` and `incrementq` functions, which calls them.

The `orw` was accidentally re-added, I will remove it in another PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20857#discussion_r1807109544