RFR: 8341068: [s390x] intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v2]
Amit Kumar
amitkumar at openjdk.org
Mon Oct 21 04:27:51 UTC 2024
On Fri, 18 Oct 2024 13:25:46 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> changes leftmost->upper and rightmost -> lower
>
> src/hotspot/cpu/s390/s390.ad line 6263:
>
>> 6261: effect(TEMP r4_reven_tmp, KILL cr);
>> 6262: // TODO: size(4);
>> 6263: format %{ "UDIV $r5_rodd_dst, $r5_rodd_dst,$src2" %}
>
> Suggestion: no whitespace between instruction operands.
Hi @RealLucy,
was that for consistency or there is issue with space in the format section?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21559#discussion_r1808085902
More information about the hotspot-compiler-dev
mailing list