RFR: 8341068: [s390x] intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v2]

[Lutz Schmidt]

On Mon, 21 Oct 2024 04:24:28 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> src/hotspot/cpu/s390/s390.ad line 6263:
>> 
>>> 6261:   effect(TEMP r4_reven_tmp, KILL cr);
>>> 6262:   // TODO: size(4);
>>> 6263:   format %{ "UDIV $r5_rodd_dst, $r5_rodd_dst,$src2" %}
>> 
>> Suggestion: no whitespace between instruction operands.
>
> Hi @RealLucy, 
> was that for consistency or there is issue with space in the format section?

It was just for consistency. As long as you don't parse the OptoAssembly output, it is purely eye candy.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21559#discussion_r1808264322