RFR: 8342962: [s390x] TestOSRLotsOfLocals.java crashes

[Lutz Schmidt]

On Fri, 25 Oct 2024 06:28:02 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> We are on thin ice with the `TestOSRLotsOfLocals` test. Before it breaks, I'd like to provide the fix. :-)
> 
> Testing : Tier1 test with fastdebug vm.

Just some academic improvements...

src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp line 144:

> 142:       // z_lg can only handle displacement upto 20bit signed binary integer
> 143:       __ load_const(Z_R0_scratch, locals_space);
> 144:       __ z_algr(OSR_buf, Z_R0_scratch);

How about using 
`__ z_algfi(OSR_buf, locals_space);`
instead?

src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp line 166:

> 164:       // Z_R0 is killed by asm_assert_mem8_isnot_zero
> 165:       __ load_const(Z_R0_scratch, locals_space);
> 166:       __ z_slgr(OSR_buf, Z_R0_scratch);

How about using 
`__ z_slgfi(OSR_buf, locals_space);`
instead?

-------------

Changes requested by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21703#pullrequestreview-2394545616
PR Review Comment: https://git.openjdk.org/jdk/pull/21703#discussion_r1816214796
PR Review Comment: https://git.openjdk.org/jdk/pull/21703#discussion_r1816215668