RFR: 8342962: [s390x] TestOSRLotsOfLocals.java crashes [v2]

Amit Kumar amitkumar at openjdk.org
Fri Oct 25 08:31:43 UTC 2024


On Fri, 25 Oct 2024 08:16:19 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments from Lutz
>
> src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp line 166:
> 
>> 164:       // Z_R0 is killed by asm_assert_mem8_isnot_zero
>> 165:       __ load_const(Z_R0_scratch, locals_space);
>> 166:       __ z_slgr(OSR_buf, Z_R0_scratch);
> 
> How about using 
> `__ z_slgfi(OSR_buf, locals_space);`
> instead?

updated :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21703#discussion_r1816240663


More information about the hotspot-compiler-dev mailing list