RFR: 8331861: [PPC64] Implement load / store assembler functions which take an Address object

Amit Kumar amitkumar at openjdk.org
Mon Oct 28 16:40:21 UTC 2024


On Thu, 24 Oct 2024 10:49:17 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Load and store assembly instructions which takes Address object as argument. 
>> 
>> Tier 1 testing successful on linux-ppc64le and aix-ppc (fastdebug level)
>> 
>> JBS : [JDK-8331861](https://bugs.openjdk.org/browse/JDK-8331861)
>
> src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp line 1090:
> 
>> 1088:       Address to   = frame_map()->address_for_double_slot(dest->double_stack_ix());
>> 1089:       __ ld(tmp, from);
>> 1090:       __ std(tmp, to.disp(), to.base());
> 
> why these store instruction left behind ? 
> 
> Can't we just pass address and give it scratch register to play with ?

Oh, we don't even need `tmp` and it defaults to `noreg`. Even better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21492#discussion_r1814747197


More information about the hotspot-compiler-dev mailing list