RFR: 8331861: [PPC64] Implement load / store assembler functions which take an Address object
Varada M
varadam at openjdk.org
Mon Oct 28 16:40:21 UTC 2024
On Thu, 24 Oct 2024 10:51:06 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp line 1090:
>>
>>> 1088: Address to = frame_map()->address_for_double_slot(dest->double_stack_ix());
>>> 1089: __ ld(tmp, from);
>>> 1090: __ std(tmp, to.disp(), to.base());
>>
>> why these store instruction left behind ?
>>
>> Can't we just pass address and give it scratch register to play with ?
>
> Oh, we don't even need `tmp` and it defaults to `noreg`. Even better.
Thanks for suggestion! I have adapted the changes for store instructions. Testing (tier1) on linux-ppc64le is successfully completed. Testing to be done for aix-ppc.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21492#discussion_r1816048992
More information about the hotspot-compiler-dev
mailing list