RFR: 8335977: Deoptimization fails with assert "object should be reallocated already" [v2]

Cesar Soares Lucas cslucas at openjdk.org
Tue Oct 29 22:50:30 UTC 2024


> Please, review this patch to fix an issue that may occur when serializing debug information related to reduce allocation merges. The problem happens when there are more than one JVMS in a `uncommon_trap` and a _younger_ JVMS doesn't have the RAM inputs as a local/expression/monitor but an older JVMS does. In that situation the loop at line 1173 of output.cpp will set the `is_root` property of the ObjectValue to `false` when processing the younger JVMS even though it may have been set to `true` when visiting the older JVMS.
> 
> Tested on: 
>  - Win, Mac & Linux tier1-4 on x64 & Aarch64.
>  - CTW with some thousands of jars.

Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:

  Address PR feedback: typo on test & refactor in output.cpp.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21624/files
  - new: https://git.openjdk.org/jdk/pull/21624/files/8e345b59..26b0b869

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21624&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21624&range=00-01

  Stats: 18 lines in 2 files changed: 8 ins; 9 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21624.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21624/head:pull/21624

PR: https://git.openjdk.org/jdk/pull/21624


More information about the hotspot-compiler-dev mailing list