RFR: 8335977: Deoptimization fails with assert "object should be reallocated already" [v2]

[Cesar Soares Lucas]

On Fri, 25 Oct 2024 23:39:39 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address PR feedback: typo on test & refactor in output.cpp.
>
> src/hotspot/share/opto/output.cpp line 1179:
> 
>> 1177:           // the younger JVMS.
>> 1178:           if (ov->is_root()) {
>> 1179:             continue;
> 
> You can either fuse `ov->is_root()` check into `is_root` computation (`bool is_root = ov->is_root() || ...`) or turn it into an `if-then-else` (`if (ov->is_root()) { /* comment */ } else { bool is_root = ...;  ov->set_root(is_root); }`). I find both cases easier to read.

Done. Thanks Vladimir.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21624#discussion_r1821618289