RFR: 8330159: [C2] Remove or clarify Compile::init_start [v3]

[Yagmur Eren]

On Sat, 31 Aug 2024 00:01:47 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Yagmur Eren has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove method header
>
> src/hotspot/share/opto/generateOptoStub.cpp line 264:
> 
>> 262:                                           returnadr());
>> 263:   root()->add_req(_gvn.transform(to_exc));  // bind to root to keep live
>> 264:   DEBUG_ONLY(C->verify_start(start);)
> 
> This looks fine, but instead of marking every call site with DEBUG_ONLY, how about adding NOT_DEBUG_RETURN to the declaration of verify_start(), so it is a no-op in non-debug builds?  For an example, see check_no_dead_use().

Thanks a lot for feedback @dean-long!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20715#discussion_r1740737874