RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v2]

[Emanuel Peter]

On Mon, 22 Jan 2024 09:23:05 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix tests, add verify
>
> src/hotspot/share/opto/type.hpp line 558:
> 
>> 556: 
>> 557:   // Use to compute join of 2 sets
>> 558:   const bool _dual;
> 
> I think you need to add some comments, explaining why this is here

Thanks for adding the comment! I think comments should not refer to "before this change", rather they should describe the way the code works now.

I would also recommend renaming it to `_is_dual`. Because with `_dual`, I would expect to get some kind of dual, not a bool.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1742052610