RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v7]

Emanuel Peter epeter at openjdk.org
Thu Sep 5 14:46:57 UTC 2024


On Tue, 3 Sep 2024 20:44:28 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> test/hotspot/gtest/opto/test_rangeinference.cpp line 148:
>> 
>>> 146:   test_normalize_constraints_random<jint, juint>();
>>> 147:   test_normalize_constraints_random<jlong, julong>();
>>> 148: }
>> 
>> I would appreciate it if there were some explicit examples with explicit result verification. Just to make sure the methods are not systematically wrong in some silly way.
>
> My idea is that it is what `test_normalize_constraints_simple` would do, but I think adding some more explicit cases would help, too.

Maybe you should just grep over the whole diff and look for `normal` to catch any remaining cases where it should be named `canonical` ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1745685025


More information about the hotspot-compiler-dev mailing list