RFR: 8338971: IGV: Add incrementally inlined method name to phase name [v2]

[Roberto Castañeda Lozano]

On Wed, 4 Sep 2024 06:03:54 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> This patch adds the method name to the incremental inlining step dumps in IGV which improves debugging issues involving incremental inlining:
>> 
>> 
>> static void test() {
>>     method1();
>>     method2();
>>     method3();
>> }
>> 
>> static void method1() {}
>> static void method2() {}
>> static void method3() {}
>> 
>> Run with `-XX:+AlwaysIncrementalInline` and IGV print level >=3:
>> 
>> Before patch:
>> ![image](https://github.com/user-attachments/assets/a3a1ab32-e7b3-4ccb-8ab2-a75d2b5b6912)
>> 
>> After patch:
>> ![image](https://github.com/user-attachments/assets/8100a2fe-1670-4687-b8b8-c8053fbaa7d7)
>> 
>> The patch just prints the method name if we call `print_method()` with `n` being a call node which, AFAICT, only happens for the incremental inlining step. However, even if we call it with another phase at some point, I don't think it hurts to also dump the method name there.
>> 
>> #### Testing
>> - Manually verifying change in IGV
>> - Building IGV which runs its unit tests
>> - Sanity run with a hello world program with `-Xcomp -XX:+AlwaysIncrementalInline -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=3 -XX:PrintIdealGraphFile=graph.xml`
>> 
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   suggestion

Marked as reviewed by rcastanedalo (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20834#pullrequestreview-2279135884