RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v7]

[Emanuel Peter]

On Tue, 3 Sep 2024 20:45:58 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> src/hotspot/share/opto/rangeinference.cpp line 113:
>> 
>>> 111:   T match_mask = mismatch == 0 ? std::numeric_limits<T>::max()
>>> 112:                                : ~(std::numeric_limits<T>::max() >> count_leading_zeros(mismatch));
>>> 113:   T new_zeros = bits._zeros | (match_mask &~ bounds._lo);
>> 
>> Suggestion:
>> 
>>   T new_zeros = bits._zeros | (match_mask & ~bounds._lo);
>> 
>> I think this was a typo?
>
> It looks more like an `and not` to me :) However, if you prefer the `~` to stick to `bounds._lo` I would make that change.

I was confused by it, and wondered if a `&~` operator exists in cpp... 😅
But this is only a weak preference on my side.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1743297392