RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v12]

Quan Anh Mai qamai at openjdk.org
Thu Sep 5 15:41:30 UTC 2024


On Wed, 4 Sep 2024 22:06:26 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix build
>
> src/hotspot/share/opto/type.hpp line 29:
> 
>> 27: 
>> 28: #include "opto/adlcVMDeps.hpp"
>> 29: #include "opto/compile.hpp"
> 
> Please, don't include `compile.hpp` here - it could be cyclic dependencies if not now but later.
> If you need something from it put it into `type.cpp`

It is useless, we use `Compile::current()` inside `type.hpp`, which means that `compile.hpp` must be included before `type.hpp` anyway.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1745779199


More information about the hotspot-compiler-dev mailing list