RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v12]

Vladimir Kozlov kvn at openjdk.org
Thu Sep 5 16:30:57 UTC 2024


On Thu, 5 Sep 2024 15:38:39 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> src/hotspot/share/opto/type.hpp line 29:
>> 
>>> 27: 
>>> 28: #include "opto/adlcVMDeps.hpp"
>>> 29: #include "opto/compile.hpp"
>> 
>> Please, don't include `compile.hpp` here - it could be cyclic dependencies if not now but later.
>> If you need something from it put it into `type.cpp`
>
> It is useless, we use `Compile::current()` inside `type.hpp`, which means that `compile.hpp` must be included before `type.hpp` anyway.

`useless` -> `useful`
You are right. But how it works now? Usually C++ compilers complain about missing definitions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1745816730


More information about the hotspot-compiler-dev mailing list