RFR: 8339299: C1 will miss type profile when inline final method [v4]

[kuaiwei]

On Mon, 9 Sep 2024 15:21:19 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> kuaiwei has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into c1_cha_type_profile
>>  - Simplify should_profile_receiver_type
>>  - Modify test case to use whitebox api
>>  - 8339299: C1 will miss type profile when inline final method
>
> test/hotspot/jtreg/compiler/cha/TypeProfileFinalMethod.java line 46:
> 
>> 44: public class TypeProfileFinalMethod {
>> 45:     public static void main(String[] args) throws Exception {
>> 46:        ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(
> 
> The `createLimitedTestJavaProcessBuilder` ignores any other VM flags. This mode should be used only of test too specific. 
> The 
> ` * @requires (vm.opt.TieredStoAtLevel == null | vm.opt.TieredStopAtLevel == 4)`
> means that we are going to run test with mostly any GC/Runtime and C2 stress options flags. (No C1-only)
> So it is needed to use createLimitedTestJavaProcessBuilder to accept all VM flags.
> You don't neet to test any additional VM flags until you have a reasons to suppose that something might fails. 
> Just use `createTestJavaProcessBuilder` instead.
> If you think that test shouldn't accept any addtional vm flags, use
> `@requires vm.flagless`
> instead of
>  `@requires (vm.opt.TieredStoAtLevel == null | vm.opt.TieredStopAtLevel == 4)`
> So test is executed only once and don't run if it is gong to ignore flags.

Thanks for your suggestions. The test case is dependent on tiered compilation and type profile. Is there any other option for these requirements?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20786#discussion_r1751153777