RFR: 8339299: C1 will miss type profile when inline final method [v4]

[Leonid Mesnik]

On Tue, 10 Sep 2024 02:17:18 GMT, kuaiwei <duke at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/cha/TypeProfileFinalMethod.java line 46:
>> 
>>> 44: public class TypeProfileFinalMethod {
>>> 45:     public static void main(String[] args) throws Exception {
>>> 46:        ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(
>> 
>> The `createLimitedTestJavaProcessBuilder` ignores any other VM flags. This mode should be used only of test too specific. 
>> The 
>> ` * @requires (vm.opt.TieredStoAtLevel == null | vm.opt.TieredStopAtLevel == 4)`
>> means that we are going to run test with mostly any GC/Runtime and C2 stress options flags. (No C1-only)
>> So it is needed to use createLimitedTestJavaProcessBuilder to accept all VM flags.
>> You don't neet to test any additional VM flags until you have a reasons to suppose that something might fails. 
>> Just use `createTestJavaProcessBuilder` instead.
>> If you think that test shouldn't accept any addtional vm flags, use
>> `@requires vm.flagless`
>> instead of
>>  `@requires (vm.opt.TieredStoAtLevel == null | vm.opt.TieredStopAtLevel == 4)`
>> So test is executed only once and don't run if it is gong to ignore flags.
>
> Thanks for your suggestions. The test case is dependent on tiered compilation and type profile. Is there any other option for these requirements?

I think that additionally 
* @requires vm.opt.TieredCompilation == null | vm.opt.TieredCompilation == true

You could check if test fails with ' -XX:-TieredCompilation'.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20786#discussion_r1755740769