RFR: 8332442: C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch() [v2]
Roland Westrelin
roland at openjdk.org
Tue Sep 10 11:54:05 UTC 2024
On Mon, 9 Sep 2024 20:43:17 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:
>> src/hotspot/share/opto/compile.cpp line 3174:
>>
>>> 3172: }
>>> 3173:
>>> 3174: BasicType bt = div_op == Op_DivI || div_op == Op_UDivI ? T_INT : T_LONG;
>>
>> and add a new function `Op_DivMod(BasicType bt, bool is_unsigned)` similar to `Op_ConIL` that would replace `div_mod_op` here.
>
> Added new function `Op_DivModIL(...)` as `Op_DivMod` already exists as an opcode constant and cannot be removed without significant changes to the codebase (although never referenced directly).
I don't mind using `Op_DivModIL(...)` but what happens if you remove `Op_DivMod`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20877#discussion_r1751802963
More information about the hotspot-compiler-dev
mailing list