RFR: 8332442: C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch() [v2]

[Kangcheng Xu]

On Tue, 10 Sep 2024 11:51:50 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Added new function `Op_DivModIL(...)` as `Op_DivMod` already exists as an opcode constant and cannot be removed without significant changes to the codebase (although never referenced directly).
>
> I don't mind using `Op_DivModIL(...)` but what happens if you remove `Op_DivMod`?

I would end up with some linker error:

/usr/bin/ld: /path/to/jdk/build/linux-x86_64-server-fastdebug/hotspot/variant-server/libjvm/objs/divnode.o: in function `DivModNode::DivModNode(Node*, Node*, Node*)':
/path/to/jdk/src/hotspot/share/opto/divnode.cpp:1357:(.text+0x7e99): undefined reference to `vtable for DivModNode'


It looks like all nodes (even those abstract ones like `Multi` and `Op_Multi`) is processed with `macro` and added to the enum. I don't know why but I looks intentional.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20877#discussion_r1752124651